feat: increase timeout waiting for done callback from 2 minutes to 5 … #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
|
@yirutang Thanks for raising the PR. Quick question - where did you run the code from (local vs a VM?), also did the issue resolve with 5 minutes as the timeout? |
|
@yirutang gentle bump. Could you elaborate on your findings from your stress test? Thanks! I am running a stress test run that writes as much data as possible from a VM and the test saw a lot of such errors. |
shollyman
approved these changes
Jul 18, 2022
Neenu1995
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
I ran it from a VM. Running it from local doesn't seem to have an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…minutes
In my stress test I am seeing a lot of CANCELLED: Timeout waiting for DoneCallback. failure when I am making calls to EU region, which led me to think the timeout is too short.