Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(shortsAndBigDecimals): add shorts and big decimals #1674

Merged
merged 3 commits into from
Oct 17, 2022
Merged

feat(shortsAndBigDecimals): add shorts and big decimals #1674

merged 3 commits into from
Oct 17, 2022
+188 −96

Conversation

dark0dave
Copy link
Contributor

Signed-off-by: dark0dave [email protected]

Closes #1673

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Jun 9, 2022
yirutang
yirutang reviewed Jul 26, 2022
View reviewed changes
Copy link
Contributor

@yirutang yirutang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just add some unit test to capture the fixes.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Aug 11, 2022
@dark0dave dark0dave marked this pull request as ready for review August 11, 2022 10:59
@dark0dave dark0dave requested a review from a team August 11, 2022 10:59
@dark0dave dark0dave requested a review from a team as a code owner August 11, 2022 10:59
@dark0dave dark0dave requested a review from loferris August 11, 2022 10:59
@dark0dave
Copy link
Contributor Author

@yirutang tests added, ready for review

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Aug 11, 2022
yirutang
yirutang reviewed Aug 15, 2022
View reviewed changes
Copy link
Contributor

@yirutang yirutang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. Is BigDecimal case covered?

@Neenu1995 Neenu1995 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 15, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 15, 2022
Neenu1995
Neenu1995 reviewed Aug 15, 2022
View reviewed changes
.../test/java/com/google/cloud/bigquery/storage/v1beta2/BQTableSchemaToProtoDescriptorTest.java
@@ -233,6 +233,12 @@ public void testStructComplex() throws Exception {
.setMode(TableFieldSchema.Mode.NULLABLE)
.setName("test_numeric_str")
.build();
final TableFieldSchema TEST_NUMERIC_SHORT =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since only the v1 client is updated, v1beta2 tests are not needed. Can you please remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can, I wanted to maintain backwards compat, but if thats not an issue I will change

@Neenu1995 Neenu1995 added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 29, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 29, 2022
@Neenu1995 Neenu1995 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 31, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 31, 2022
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 13, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 13, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 13, 2022
@Neenu1995 Neenu1995 merged commit 604d7df into googleapis:main Oct 17, 2022
@release-please release-please bot mentioned this pull request Oct 17, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 25, 2022
@release-please
chore(main): release 2.24.0 (#1828)
091ba92 
🤖 I have created a release *beep* *boop*
---


## [2.24.0](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.23.1...v2.24.0) (2022-10-25)


### Features

* Add getInflightWaitSeconds implementation ([#1835](https://togithub.com/googleapis/java-bigquerystorage/issues/1835)) ([b569116](https://togithub.com/googleapis/java-bigquerystorage/commit/b569116179700123e405eb7712abb136456f2f26))
* **shortsAndBigDecimals:** Add shorts and big decimals ([#1674](https://togithub.com/googleapis/java-bigquerystorage/issues/1674)) ([604d7df](https://togithub.com/googleapis/java-bigquerystorage/commit/604d7df2afa54e445a4d310e5293d8d19901d565))


### Bug Fixes

* **java:** Restore native image configurations ([#1844](https://togithub.com/googleapis/java-bigquerystorage/issues/1844)) ([8ce670a](https://togithub.com/googleapis/java-bigquerystorage/commit/8ce670a487a192807ccfd58613fc271d9402ca7c))
* Remove the client lib header setting since after router migration, it is no longer needed ([#1842](https://togithub.com/googleapis/java-bigquerystorage/issues/1842)) ([5f3b821](https://togithub.com/googleapis/java-bigquerystorage/commit/5f3b8214116b17b315d589bfde184e0e045cff69))


### Dependencies

* Update dependency com.google.auto.value:auto-value to v1.10 ([#1825](https://togithub.com/googleapis/java-bigquerystorage/issues/1825)) ([f7b8f2b](https://togithub.com/googleapis/java-bigquerystorage/commit/f7b8f2b4df8ca9b306a75d46eb223124ac9bdebb))
* Update dependency com.google.auto.value:auto-value-annotations to v1.10 ([#1826](https://togithub.com/googleapis/java-bigquerystorage/issues/1826)) ([37eb8a1](https://togithub.com/googleapis/java-bigquerystorage/commit/37eb8a1df34e8ae4d5e2849c76d9a591ec5505d4))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.17.1 ([#1829](https://togithub.com/googleapis/java-bigquerystorage/issues/1829)) ([7e8d900](https://togithub.com/googleapis/java-bigquerystorage/commit/7e8d90037f5ae426882f90ab251d315767b3a6b7))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.5 ([#1840](https://togithub.com/googleapis/java-bigquerystorage/issues/1840)) ([474756b](https://togithub.com/googleapis/java-bigquerystorage/commit/474756bd6547254ed6d761a73f2e69920fa79458))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
gcf-owl-bot bot added a commit that referenced this pull request Oct 28, 2022
@gcf-owl-bot
Revert "chore(deps): update dependency protobuf to v3.20.2" (#1674)
c21520c 
Revert "chore(deps): update dependency protobuf to v3.20.2 (#1659)"

This reverts commit b59cf7b5a91ecab29e21fdfbb7e3b81066229be4.
Source-Link: googleapis/synthtool@a66e346
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd316b9a591c45264775ecaba72e37d65905925c323b68e51a08c4126e4b6d0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neenu1995 Neenu1995 Neenu1995 left review comments

@yirutang yirutang yirutang approved these changes

@loferris loferris Awaiting requested review from loferris

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Shorts and BigDecimal for Numeric and BigNumeric Types
4 participants
@dark0dave @Neenu1995 @yirutang @yoshi-kokoro