fix: doubles and floats as numerics

[dark0dave]

Allows floating point numbers to be numerics and big numerics.
Fixes #1516

[stephaniewang526]

Hi, any update on this?

[dark0dave]

yep fixing up now.

[dark0dave]

let me fix the tests

[stephaniewang526]

any update on this?

[dark0dave]

@stephaniewang526 apologies, been busy. Going to run tests now to see if I missed anything.

[dark0dave]

@stephaniewang526 should be good now.

[feamcor]

This code new BigDecimal(((Number)val).doubleValue() is problematic as it generates an instance of BigDecimal (that is historically flawed) with a scale greater than what NUMERIC and BIGNUMERIC can cope with (9 and 38 digits specifically).

Example: A Double of value 133.36 is converted to a BigDecimal of value 133.3600000000000136424205265939235687255859375, resulting on the following exception: java.lang.IllegalArgumentException: ByteString scale cannot exceed 9: 133.3600000000000136424205265939235687255859375.

I recommend to change the code to take the Float/Double convert it to String and create the BigDecimal from the String.

Thanks.