docs(samples): add finalize call to our samples #1471
Merged
+16
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
api: bigquerystorage
yirutang
changed the title
| @@ -64,7 +65,9 @@ public static void writeCommittedStream(String projectId, String datasetName, St | |||
| try (JsonStreamWriter writer = | |||
| JsonStreamWriter.newBuilder(writeStream.getName(), writeStream.getTableSchema()) | |||
| .build()) { | |||
| // Write two batches to the stream, each with 10 JSON records. | |||
| // Write two batches to the stream, each with 10 JSON records. A writer should be | |||
| // used for as much writes as possible. Create a writer for just one write is an | |||
There was a problem hiding this comment.
Done. and added some more change to buffered stream. PTAL.
stephaniewang526
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
stephaniewang526
changed the title
stephaniewang526
changed the title
stephaniewang526
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
stephaniewang526
approved these changes
Jan 10, 2022
stephaniewang526
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
stephaniewang526
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 25, 2022
🤖 I have created a release *beep* *boop* --- ### [2.8.2](v2.8.1...v2.8.2) (2022-01-25) ### Bug Fixes * **java:** add reflection configuration for native-image testing ([#1488](#1488)) ([d87fe28](d87fe28)) ### Documentation * **samples:** add finalize call to our samples ([#1471](#1471)) ([47e3654](47e3654)) * **samples:** update to v1 in doc URls ([#1489](#1489)) ([7efe427](7efe427)) ### Dependencies * exclude un-used runtime dependencies brought in by gax-grpc ([#1490](#1490)) ([3e7833e](3e7833e)) * update dependency com.google.cloud:google-cloud-bigquery to v2.6.1 ([#1473](#1473)) ([f996cdb](f996cdb)) * update dependency com.google.cloud:google-cloud-bigquery to v2.6.2 ([#1475](#1475)) ([37c1fd8](37c1fd8)) * update dependency kr.motd.maven:os-maven-plugin to v1.7.0 ([#1476](#1476)) ([e038151](e038151)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️