fix: split connection pool based on credential #2388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
yirutang
reviewed
Jan 31, 2024
| @@ -273,14 +278,18 @@ private StreamWriter(Builder builder) throws IOException { | |||
| } | |||
| } | |||
| this.location = location; | |||
| CredentialsProvider credentialsProvider = client.getSettings().getCredentialsProvider(); | |||
| log.warning("The credentials gotten is " + credentialsProvider.getCredentials()); | |||
There was a problem hiding this comment.
Why are we printing this out?
There was a problem hiding this comment.
wrong debug log, removed
| ConnectionPoolKey.create(location), | ||
| ConnectionPoolKey.create( | ||
| location, | ||
| credentialsProvider != null ? credentialsProvider.getCredentials() : null), |
There was a problem hiding this comment.
Should we use a hash for the key instead? I am wondering if there could be a security concern here.
There was a problem hiding this comment.
Changed to use hash
GaoleMeng
force-pushed
the
main
branch
4 times, most recently
from
09fa9f4 to
8d661a9
Compare
yirutang
approved these changes
Feb 1, 2024
GaoleMeng
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
GaoleMeng
force-pushed
the
main
branch
2 times, most recently
from
7dc6243 to
a8c01ed
Compare
GaoleMeng
force-pushed
the
main
branch
2 times, most recently
from
c03fe54 to
fb34006
Compare
GaoleMeng
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
zhumin8
added a commit
that referenced
this pull request
Oct 3, 2024
…-config (#2679) These dependencies were added in #2388 with hardcoded versions. We prefer getting these versions from sdk-platform-java-config (includes both auth and gax versions). auth is included in dependencyManagement here in gapic-generator-java-bom, which is part of first-party-dependencies, and eventually included via sdk-platform-java-config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.