-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BigQuery Storage Write API: JsonStreamWriter cannot transform BigDecimal with 9+ decimals to BigNumeric #2013
Labels
api: bigquerystorage
Issues related to the googleapis/java-bigquerystorage API.
Comments
product-auto-label
bot
added
the
api: bigquerystorage
Issues related to the googleapis/java-bigquerystorage API.
label
Feb 23, 2023
4 tasks
4 tasks
4 tasks
gcf-merge-on-green bot
pushed a commit
that referenced
this issue
Mar 8, 2023
…2031) - [x] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigquerystorage/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) Fixes #2013
gcf-merge-on-green bot
pushed a commit
that referenced
this issue
Mar 13, 2023
🤖 I have created a release *beep* *boop* --- ## [2.34.0](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.33.1...v2.34.0) (2023-03-10) ### Features * Add routing header for multiplexed connection ([#2035](https://togithub.com/googleapis/java-bigquerystorage/issues/2035)) ([1f2752f](https://togithub.com/googleapis/java-bigquerystorage/commit/1f2752f3988ac87dca50813d69d0d519a2356a30)) ### Bug Fixes * **bigdecimal:** Convert BigDecimal to BigNumeric instead of Numeric ([#2031](https://togithub.com/googleapis/java-bigquerystorage/issues/2031)) ([e0f7e34](https://togithub.com/googleapis/java-bigquerystorage/commit/e0f7e34ca7f7c60279985afec46f780e0acc9a9e)), closes [#2013](https://togithub.com/googleapis/java-bigquerystorage/issues/2013) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
yirutang
pushed a commit
to yirutang/java-bigquerystorage
that referenced
this issue
Mar 22, 2023
🤖 I have created a release *beep* *boop* --- ## [2.34.0](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.33.1...v2.34.0) (2023-03-10) ### Features * Add routing header for multiplexed connection ([googleapis#2035](https://togithub.com/googleapis/java-bigquerystorage/issues/2035)) ([1f2752f](https://togithub.com/googleapis/java-bigquerystorage/commit/1f2752f3988ac87dca50813d69d0d519a2356a30)) ### Bug Fixes * **bigdecimal:** Convert BigDecimal to BigNumeric instead of Numeric ([googleapis#2031](https://togithub.com/googleapis/java-bigquerystorage/issues/2031)) ([e0f7e34](https://togithub.com/googleapis/java-bigquerystorage/commit/e0f7e34ca7f7c60279985afec46f780e0acc9a9e)), closes [googleapis#2013](https://togithub.com/googleapis/java-bigquerystorage/issues/2013) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment details
Steps to reproduce
BIGNUMERIC
24.6789012345
Code example
This unit test could be added to
JsonToProtoMessageTest
to reproduce it:Stack trace
Any additional information below
On the following lines,
encodeToBigNumericByteString
should be called instead ofencodeToNumericByteString
:If you agree on this proposed approach, we can create PR with the following fix:
main...tradecloud:java-bigquerystorage:TC-8710-serialize-bigdecimal
The text was updated successfully, but these errors were encountered: