-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add getInflightWaitSeconds implementation #1835
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prerequisite for multiplexing client
new stream name as a switch of destinationt
also fixed a tiny bug inside fake bigquery write impl for getting thre response from offset
possible the proto schema does not contain this field
possible the proto schema does not contain this field
product-auto-label
bot
added
size: m
Pull request size is medium.
api: bigquerystorage
Issues related to the googleapis/java-bigquerystorage API.
labels
Oct 13, 2022
yirutang
reviewed
Oct 13, 2022
...e-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/StreamWriter.java
Show resolved
Hide resolved
yirutang
approved these changes
Oct 17, 2022
@@ -60,7 +61,8 @@ | |||
@RunWith(JUnit4.class) | |||
public class StreamWriterTest { | |||
private static final Logger log = Logger.getLogger(StreamWriterTest.class.getName()); | |||
private static final String TEST_STREAM = "projects/p/datasets/d/tables/t/streams/s"; | |||
private static final String TEST_STREAM_1 = "projects/p/datasets/d/tables/t/streams/s"; | |||
private static final String TEST_STREAM_2 = "projects/p/datasets/d/tables/t/streams/s"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be a different name?
yirutang
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Oct 18, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Oct 18, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Oct 25, 2022
🤖 I have created a release *beep* *boop* --- ## [2.24.0](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.23.1...v2.24.0) (2022-10-25) ### Features * Add getInflightWaitSeconds implementation ([#1835](https://togithub.com/googleapis/java-bigquerystorage/issues/1835)) ([b569116](https://togithub.com/googleapis/java-bigquerystorage/commit/b569116179700123e405eb7712abb136456f2f26)) * **shortsAndBigDecimals:** Add shorts and big decimals ([#1674](https://togithub.com/googleapis/java-bigquerystorage/issues/1674)) ([604d7df](https://togithub.com/googleapis/java-bigquerystorage/commit/604d7df2afa54e445a4d310e5293d8d19901d565)) ### Bug Fixes * **java:** Restore native image configurations ([#1844](https://togithub.com/googleapis/java-bigquerystorage/issues/1844)) ([8ce670a](https://togithub.com/googleapis/java-bigquerystorage/commit/8ce670a487a192807ccfd58613fc271d9402ca7c)) * Remove the client lib header setting since after router migration, it is no longer needed ([#1842](https://togithub.com/googleapis/java-bigquerystorage/issues/1842)) ([5f3b821](https://togithub.com/googleapis/java-bigquerystorage/commit/5f3b8214116b17b315d589bfde184e0e045cff69)) ### Dependencies * Update dependency com.google.auto.value:auto-value to v1.10 ([#1825](https://togithub.com/googleapis/java-bigquerystorage/issues/1825)) ([f7b8f2b](https://togithub.com/googleapis/java-bigquerystorage/commit/f7b8f2b4df8ca9b306a75d46eb223124ac9bdebb)) * Update dependency com.google.auto.value:auto-value-annotations to v1.10 ([#1826](https://togithub.com/googleapis/java-bigquerystorage/issues/1826)) ([37eb8a1](https://togithub.com/googleapis/java-bigquerystorage/commit/37eb8a1df34e8ae4d5e2849c76d9a591ec5505d4)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.17.1 ([#1829](https://togithub.com/googleapis/java-bigquerystorage/issues/1829)) ([7e8d900](https://togithub.com/googleapis/java-bigquerystorage/commit/7e8d90037f5ae426882f90ab251d315767b3a6b7)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.5 ([#1840](https://togithub.com/googleapis/java-bigquerystorage/issues/1840)) ([474756b](https://togithub.com/googleapis/java-bigquerystorage/commit/474756bd6547254ed6d761a73f2e69920fa79458)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigquerystorage
Issues related to the googleapis/java-bigquerystorage API.
size: m
Pull request size is medium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.