feat: Add CANCELLED to StreamWriter retryable error code #1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
bot
added
size: xs
yirutang
changed the title
gnanda
approved these changes
Aug 1, 2022
...e-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/StreamWriter.java
Show resolved
Hide resolved
yirutang
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
yirutang
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
yirutang
added
kokoro:run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:run
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Aug 5, 2022
🤖 I have created a release *beep* *boop* --- ## [2.19.0](v2.18.0...v2.19.0) (2022-08-05) ### Features * Add CANCELLED to StreamWriter retryable error code ([#1725](#1725)) ([6d4c004](6d4c004)) * remove a dummy WriterClosedException ([0b3018d](0b3018d)) ### Bug Fixes * Switch integration test onto v1 write api ([#1731](#1731)) ([2ccb96e](2ccb96e)) ### Documentation * **owlbot-java:** explaining why not using formatter in pom.xml ([#1511](#1511)) ([#1723](#1723)) ([eabfa93](eabfa93)), closes [#1502](#1502) ### Dependencies * update arrow.version to v9 (major) ([#1728](#1728)) ([3694243](3694243)) * update dependency com.google.cloud:google-cloud-bigquery to v2.14.1 ([#1721](#1721)) ([e27a9e9](e27a9e9)) * update dependency com.google.cloud:google-cloud-bigquery to v2.14.2 ([#1734](#1734)) ([0115e98](0115e98)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#1718](#1718)) ([940c613](940c613)) * update dependency org.apache.arrow:arrow-memory-netty to v9 ([#1729](#1729)) ([297ee99](297ee99)) * update dependency org.apache.arrow:arrow-vector to v9 ([#1730](#1730)) ([6010b42](6010b42)) * update dependency org.apache.avro:avro to v1.11.1 ([#1719](#1719)) ([754296f](754296f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer hitting a general grpc channel cancelled error due to server side cancel the channel:
throwable com.google.cloud.bigquery.storage.v1.Exceptions$StreamWriterClosedException: FAILED_PRECONDITION: Connection is closed due to com.google.api.gax.rpc.CancelledException: io.grpc.StatusRuntimeException: CANCELLED: Failed to read message.
Since we have user_closed flag to guard writer close, it is fine to retry on Cancelled error, so user side saw less error.