feat!: remove a dummy WriterClosedException (#1726)

* feat: Remove a dummy WriterClosedException * . * . * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
googleapis · Aug 4, 2022 · 0b3018d · 0b3018d
1 parent 3694243
commit 0b3018d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/google-cloud-bigquerystorage/clirr-ignored-differences.xml b/google-cloud-bigquerystorage/clirr-ignored-differences.xml
@@ -11,4 +11,8 @@
     <className>com/google/cloud/bigquery/storage/v1/Exceptions$StreamFinalizedException</className>
     <method>Exceptions$StreamFinalizedException(io.grpc.Status, io.grpc.Metadata, java.lang.String)</method>
   </difference>
+  <difference>
+    <differenceType>8001</differenceType>
+    <className>com/google/cloud/bigquery/storage/v1/Exceptions$WriterClosedException</className>
+  </difference>
 </differences>
diff --git a/...-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/Exceptions.java b/...-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/Exceptions.java
@@ -29,11 +29,6 @@
 
 /** Exceptions for Storage Client Libraries. */
 public final class Exceptions {
-  public static class WriterClosedException extends Exception {
-    public WriterClosedException(String streamName) {
-      super("Writer closed on: " + streamName);
-    }
-  }
   /** Main Storage Exception. Might contain map of streams to errors for that stream. */
   public static class StorageException extends StatusRuntimeException {
 

diff --git a/...loud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/StreamWriter.java b/...loud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/StreamWriter.java
@@ -562,7 +562,11 @@ private AppendRowsRequest prepareRequestBasedOnPosition(
   }
 
   private void cleanupInflightRequests() {
-    Throwable finalStatus = new Exceptions.WriterClosedException(streamName);
+    Throwable finalStatus =
+        new Exceptions.StreamWriterClosedException(
+            Status.fromCode(Status.Code.FAILED_PRECONDITION)
+                .withDescription("Connection is already closed, cleanup inflight request"),
+            streamName);
     Deque<AppendRequestAndResponse> localQueue = new LinkedList<AppendRequestAndResponse>();
     this.lock.lock();
     try {