Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Spanner V2 #7825

Closed
wants to merge 8 commits into from
Closed

feat!: Spanner V2 #7825

wants to merge 8 commits into from

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Nov 12, 2024

TODO

  • consider alternatives to withResultFunction(), such as MessageActiveRecordInterface::fromMessage(Message $message). which would allow the OperationResponse to call this method in order to "hydrate" the protobuf object
  • investigate why info methods are now returning values for all fields
    • looked into this, it seems like V1 and V2 work the same, but the way the tests were written in V1, the response was mocked to not include all the fields.
  • investigate project ID detection (it isn't working for V2 like it does for V1)
  • Look into "Project ID Detection", which doesn't seem to be working well
  • Investigate why multiplexedSessionPreviousTransactionId needed to be added to tests

TBD:

  • can we remove the longRunningOperation methods on the handwritten classes in favor of using the existing list*Operations methods?
  • What is the appropriate behavior when resumeOperation is called on a database for an instance operation?

@bshaffer
Copy link
Contributor Author

bshaffer commented Nov 16, 2024

closing in order to split this into two PRs.

See #7840 and #7841

@bshaffer bshaffer closed this Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant