Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(spanner): enable PG tests to run on emulator #7572

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(spanner): enable PG tests to run on emulator #7572

wants to merge 2 commits into from

Conversation

skuruppu
Copy link
Contributor

@skuruppu skuruppu commented Aug 2, 2024

No description provided.

@skuruppu skuruppu requested review from a team as code owners August 2, 2024 00:17
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Aug 2, 2024
@skuruppu skuruppu force-pushed the spanner-enable-emulator-tests branch 5 times, most recently from f422af1 to cc4d367 Compare August 2, 2024 06:29
bshaffer
bshaffer reviewed Aug 2, 2024
View reviewed changes
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but the emulator tests are failing so I suppose something is still wrong. is it because the emulator version needs to be updated?

Spanner/tests/System/PgBatchWriteTest.php Outdated Show resolved Hide resolved
Spanner/tests/System/SpannerPgTestCase.php Outdated Show resolved Hide resolved
Spanner/tests/System/SpannerPgTestCase.php Outdated Show resolved Hide resolved
@skuruppu
Copy link
Contributor Author

skuruppu commented Aug 5, 2024

This looks good, but the emulator tests are failing so I suppose something is still wrong. is it because the emulator version needs to be updated?

Thanks for the quick reply @bshaffer. Unfortunately, I haven't been able to get the tests to pass so this PR needs work. I don't think it's a version issue. I think there are either gaps in the PG support in the emulator or the calls are being made in a way that's not supported by the emulator.

I haven't been able to get the tests to run locally to figure out what's going on. I'll keep trying and get back to you.

@bshaffer
Copy link
Contributor

bshaffer commented Aug 5, 2024

@skuruppu follow the steps in our spanner emulator workflow to run the emulator tests. Note that they require docker.

@skuruppu skuruppu force-pushed the spanner-enable-emulator-tests branch from cc4d367 to 75aec95 Compare September 13, 2024 01:41
@skuruppu skuruppu force-pushed the spanner-enable-emulator-tests branch from 75aec95 to 221bf28 Compare September 13, 2024 01:46
@skuruppu
Copy link
Contributor Author

@bshaffer sorry for the delay. I finally got back to this resolved the issues. The tests now pass against the emulator but ones with known failures are skipped (with explanations).

PTAL

@skuruppu skuruppu requested a review from bshaffer September 23, 2024 04:34
@skuruppu
Copy link
Contributor Author

Friendly ping @bshaffer on the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshaffer bshaffer Awaiting requested review from bshaffer

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skuruppu @bshaffer