Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(storage): refactor retention_period to retention_duration #7203

Merged
merged 1 commit into from
Jan 4, 2023
Merged

chore(storage): refactor retention_period to retention_duration #7203

merged 1 commit into from
Jan 4, 2023

Conversation

noahdietz
Copy link
Contributor

Refactor use of RetentionPolicy.retention_period to RetentionPolicy.retention_duration.

@noahdietz noahdietz requested review from a team as code owners January 3, 2023 23:22
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the Cloud Storage API. labels Jan 3, 2023
@noahdietz noahdietz requested a review from tritone January 3, 2023 23:22
tritone
tritone approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the API change goes through

@noahdietz noahdietz merged commit 02c04a7 into googleapis:main Jan 4, 2023
@noahdietz noahdietz deleted the retention-duration branch January 4, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noahdietz @tritone