Skip to content

Commit

Permalink
spanner/request-id: some methods like Cleanup do not do retries autom…
Browse files Browse the repository at this point in the history
…atically
  • Loading branch information
odeke-em committed Nov 1, 2024
1 parent be21eb0 commit 7785a60
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions spanner/batch.go
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,6 @@ func (t *BatchReadOnlyTransaction) PartitionReadUsingIndexWithOptions(ctx contex
}
var md metadata.MD
sh.updateLastUseTime()
// TODO: (@odeke-em) retrieve the requestID and increment the RPC number
// then send it along in every call per retry.
resp, err = client.PartitionRead(contextWithOutgoingMetadata(ctx, sh.getMetadata(), t.disableRouteToLeader), &sppb.PartitionReadRequest{
Session: sid,
Transaction: ts,
Expand Down Expand Up @@ -286,8 +284,6 @@ func (t *BatchReadOnlyTransaction) Cleanup(ctx context.Context) {
t.sh = nil
sid, client := sh.getID(), sh.getClient()

// TODO: (@odeke-em) retrieve the requestID and increment the RPC number
// then send it along in every call per retry.
var md metadata.MD
err := client.DeleteSession(contextWithOutgoingMetadata(ctx, sh.getMetadata(), true), &sppb.DeleteSessionRequest{Name: sid}, gax.WithGRPCOptions(grpc.Header(&md)))

Expand Down

0 comments on commit 7785a60

Please sign in to comment.