This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
chore: downstream check for all libraries in single job #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanseokoh
reviewed
Jan 5, 2022
Neenu1995
changed the title
Co-authored-by: Chanseok Oh <[email protected]>
Co-authored-by: Chanseok Oh <[email protected]>
Co-authored-by: Chanseok Oh <[email protected]>
Co-authored-by: Chanseok Oh <[email protected]>
Co-authored-by: Chanseok Oh <[email protected]>
Co-authored-by: Chanseok Oh <[email protected]>
lesv
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
Generally happy, see comments in googleapis/java-core#621 and apply them to this PR as well.
Neenu1995
changed the title
lesv
approved these changes
Feb 9, 2022
lesv
reviewed
Feb 9, 2022
lesv
approved these changes
Feb 9, 2022
|
It would be nice to understand why we have single failures in other PR's of this kind, but 4 here. |
There are more failures in this PR than others because of a flaky test in gax. This has been fixed recently and shouldn't show up one the PR is merged/rebased. |
|
Kudos, SonarCloud Quality Gate passed!
|
lesv
approved these changes
Feb 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test core java libraries in java client libraries before release. Feature/code changes introduced in each PR can be tested on downstream java client libraries by adding
downstream-check:runlabel. For now, unit tests are being run.Next phase involves running samples and integration tests.
Note: Some of these tests are expected to fail due to individual client library conditions and do block the merging of this PR.