Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Remove @BetaApi from LRO and streaming classes #702

Closed
garrettjonesgoogle opened this issue Apr 5, 2019 · 3 comments
Closed

Remove @BetaApi from LRO and streaming classes #702

garrettjonesgoogle opened this issue Apr 5, 2019 · 3 comments
Assignees
@vam-google
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@garrettjonesgoogle
Copy link
Member

The LRO & Streaming classes (client streaming, server streaming, bidi streaming) haven't been changed for a while, so we should remove @BetaApi so that they are considered stable.
@garrettjonesgoogle garrettjonesgoogle mentioned this issue Apr 5, 2019
Closed
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Apr 6, 2019
@vam-google vam-google added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: cleanup An internal cleanup or hygiene concern. labels Apr 8, 2019
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Apr 8, 2019
@andreamlin
Copy link
Contributor

ack

@andreamlin
Copy link
Contributor

i would want to regenerate the LRO client first before taking the @BetaApi annotation off those files

@andreamlin andreamlin mentioned this issue Apr 9, 2019
Closed
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Apr 14, 2019
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Apr 24, 2019
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels May 4, 2019
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels May 14, 2019
@sduskis sduskis removed 🚨 This issue needs some love. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jun 12, 2019
@andreamlin andreamlin assigned yihanzhen and unassigned andreamlin Jun 14, 2019
@yihanzhen yihanzhen removed their assignment Jun 17, 2019
@miraleung miraleung assigned miraleung and unassigned vam-google Jun 2, 2020
@miraleung miraleung linked a pull request Jun 2, 2020 that will close this issue
[gax-java] Remove @BetaApi from LRO and Streaming APIs #1094
Closed
@vam-google vam-google assigned vam-google and unassigned miraleung Feb 9, 2022
vam-google added a commit to vam-google/gax-java that referenced this issue Feb 10, 2022
@vam-google
chore: Remove @BetaApi annotations for the de-facto GA features
533617e 
Those features have been under `BetaApi` annotation for 2-3+ years.
They are:
- Long running operations logic
- Streaming logic
- Fields extractor logic
- Interceptors logic
- Response metadata logic

Few things were deprecated instead of "de-beta'ed":
- `Pages` class
- `Distribution` class

those classes are a dead code and probably were used by the already-deleted benchmark module.

Many of the classes under gax-httpjson module remain `BetaApi` as those are much younger than grpc and shared classes, and will be cleaned up with httpjson module GA (which whill hopefully happen in H1).

This also addresses a couple old issues: googleapis#1095 and googleapis#702
@vam-google vam-google mentioned this issue Feb 10, 2022
Merged
vam-google added a commit that referenced this issue Feb 11, 2022
@vam-google
chore: Remove @BetaApi annotations for the de-facto GA features (#1627
837a90b 
)

* chore: Remove `@BetaApi` annotations for the de-facto GA features

Those features have been under `BetaApi` annotation for 2-3+ years.
They are:
- Long running operations logic
- Streaming logic
- Fields extractor logic
- Interceptors logic
- Response metadata logic

Many of the classes under gax-httpjson module remain `BetaApi` as those are much younger than grpc and shared classes, and will be cleaned up with httpjson module GA (which whill hopefully happen in H1).

This also addresses a couple old issues: #1095 and #702

* undeprecate Distribution and Pages
@vam-google
Copy link
Contributor

The annotations have been removed.

suztomo pushed a commit to googleapis/sdk-platform-java that referenced this issue Dec 16, 2022
@vam-google
chore: Remove @BetaApi annotations for the de-facto GA features (#1627
6101079 
)

* chore: Remove `@BetaApi` annotations for the de-facto GA features

Those features have been under `BetaApi` annotation for 2-3+ years.
They are:
- Long running operations logic
- Streaming logic
- Fields extractor logic
- Interceptors logic
- Response metadata logic

Many of the classes under gax-httpjson module remain `BetaApi` as those are much younger than grpc and shared classes, and will be cleaned up with httpjson module GA (which whill hopefully happen in H1).

This also addresses a couple old issues: googleapis/gax-java#1095 and googleapis/gax-java#702

* undeprecate Distribution and Pages
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vam-google vam-google

Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[gax-java] Remove @BetaApi from LRO and Streaming APIs googleapis/gax-java
7 participants
@sduskis @andreamlin @miraleung @garrettjonesgoogle @vam-google @yihanzhen @yoshi-automation