Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use response body message as error message when possible #297

Merged
merged 3 commits into from
Sep 27, 2018

Conversation

nolanmar511
Copy link
Contributor

When an error occurs when collecting a profile, right now, the status message of the response is logged at the debug level.

This change makes it so the response body's message is logged instead when possible, hopefully making the debug logs clearer.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 18, 2018
@codecov
Copy link

codecov bot commented Sep 18, 2018

Codecov Report

Merging #297 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #297      +/-   ##
==========================================
+ Coverage    89.7%   89.85%   +0.14%     
==========================================
  Files           6        6              
  Lines         408      414       +6     
  Branches       73       74       +1     
==========================================
+ Hits          366      372       +6     
  Misses         42       42
Impacted Files Coverage Δ
ts/src/profiler.ts 96.06% <100%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cb8355...3a256bc. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Sep 18, 2018

Codecov Report

Merging #297 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #297      +/-   ##
==========================================
+ Coverage    89.7%   89.85%   +0.14%     
==========================================
  Files           6        6              
  Lines         408      414       +6     
  Branches       73       74       +1     
==========================================
+ Hits          366      372       +6     
  Misses         42       42
Impacted Files Coverage Δ
ts/src/profiler.ts 96.06% <100%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cb8355...3a256bc. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 18, 2018

Codecov Report

Merging #297 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #297      +/-   ##
==========================================
+ Coverage    89.7%   89.85%   +0.14%     
==========================================
  Files           6        6              
  Lines         408      414       +6     
  Branches       73       74       +1     
==========================================
+ Hits          366      372       +6     
  Misses         42       42
Impacted Files Coverage Δ
ts/src/profiler.ts 96.06% <100%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15ae5e4...3e0eff3. Read the comment docs.

@nolanmar511 nolanmar511 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 18, 2018
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants