fix(deps): update dependency @google-cloud/common to ^0.23.0 #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking changes in common: common was split in multiple modules, HTTP dependency must be passed in by client library. Fixes: googleapis/nodejs-common#204 Fixes: googleapis#266
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #281 +/- ##
=========================================
- Coverage 89.75% 89.7% -0.06%
=========================================
Files 6 6
Lines 410 408 -2
Branches 72 73 +1
=========================================
- Hits 368 366 -2
Misses 42 42
Continue to review full report at Codecov.
|
|
@fhinkel Looks like there are merge conflicts in ts/test/test-heap-profiler.ts? Also appveyor CI check is red, PTAL. |
ofrobots
approved these changes
Aug 23, 2018
| super({ | ||
| parent: new Service(serviceConfig, config), | ||
| baseUrl: '/', | ||
| requestModule: request |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
CI is green and merge ist resolved. Can somebody land this? (Or give me write access). Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes in common: common was split in multiple modules, HTTP
dependency must be passed in by client library.
Fixes: googleapis/nodejs-common#204
Fixes: #266