chore: generate package-lock.json in npm-audit presubmit check #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
nolanmar511
force-pushed
the
update-audit
branch
from
b32d5ed to
09d083c
Compare
Codecov Report
@@ Coverage Diff @@
## master #269 +/- ##
======================================
Coverage 90.2% 90.2%
======================================
Files 6 6
Lines 398 398
Branches 70 70
======================================
Hits 359 359
Misses 39 39Continue to review full report at Codecov.
|
aalexand
approved these changes
Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #267, the npm audit check has been failing since there is not package-lock.json.
The PR modifies the npm audit presubmit test so a package-lock.json is generated before npm audit is run.