Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(package): update dep protobufjs #246

Merged
merged 1 commit into from
Jun 28, 2018
Merged

chore(package): update dep protobufjs #246

merged 1 commit into from
Jun 28, 2018

Conversation

ofrobots
Copy link
Contributor

No description provided.

@ofrobots ofrobots requested a review from nolanmar511 June 27, 2018 21:26
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 27, 2018
nolanmar511
nolanmar511 approved these changes Jun 27, 2018
View reviewed changes
Copy link
Contributor

@nolanmar511 nolanmar511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI/kokoro all pass.

@codecov
Copy link

codecov bot commented Jun 28, 2018 •
edited
Loading

Codecov Report

Merging #246 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #246   +/-   ##
=======================================
  Coverage   89.94%   89.94%           
=======================================
  Files           6        6           
  Lines         388      388           
  Branches       69       69           
=======================================
  Hits          349      349           
  Misses         39       39

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e038d69...4b1d3e6. Read the comment docs.

@ofrobots ofrobots merged commit 046d3ed into googleapis:master Jun 28, 2018
@ofrobots ofrobots deleted the update-protobufjs branch June 28, 2018 15:46
@snyk-bot snyk-bot mentioned this pull request Feb 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolanmar511 nolanmar511 nolanmar511 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofrobots @nolanmar511 @googlebot