chore: reduce verbosity of e2e test output #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #173 +/- ##
======================================
Coverage 94.7% 94.7%
======================================
Files 6 6
Lines 359 359
Branches 59 59
======================================
Hits 340 340
Misses 19 19Continue to review full report at Codecov.
|
aalexand
reviewed
Apr 4, 2018
testing/integration_test.go
Outdated
| @@ -54,14 +55,14 @@ set -eo pipefail | |||
| # Display commands being run | |||
| set -x | |||
| # Install git | |||
| apt-get update | |||
| apt-get -y -q install git build-essential | |||
| apt-get update > /dev/null | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -54,14 +55,14 @@ set -eo pipefail | |||
| # Display commands being run | |||
| set -x | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
PTAL |
aalexand
approved these changes
Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates e2e test to be compatible with changes made to github.com/GoogleCloudPlatform/google-cloud-go/profiler/proftest here, and reduce verbosity of logs.
This should be merged in when Kokoro CI test is passing. At that point, Kokoro tests without this change will be expected to fail.