-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add caching dupe change #835
Conversation
Thanks for this, @dorryspears ! I'm not a GitHub Actions expert, so I may be off the mark here, but will making this a "step" rather than a |
@joshlf You are right. I now understand what the CI was doing. I rearranged my code and added back the generate cache step. That action just replaces the - uses: actions/cache@13aacd865c20de90d75de3b17ebe84f7a17d57d2 # v4.0.0
with:
path: |
~/.cargo/
key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.toml') }} step in the existing jobs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay awesome, thanks! A few nits regarding stray whitespace, but this looks good!
Co-authored-by: Joshua Liebow-Feeser <[email protected]>
Co-authored-by: Joshua Liebow-Feeser <[email protected]>
Co-authored-by: Joshua Liebow-Feeser <[email protected]>
* fixed cache dupe call * add shell * Removed duplicate calls for caching in CI. Resolves google#340 * fixed multiple runs * removed whitespace .github/workflows/ci.yml Co-authored-by: Joshua Liebow-Feeser <[email protected]> * removed whitespace .github/workflows/ci.yml Co-authored-by: Joshua Liebow-Feeser <[email protected]> * removed whitespace .github/workflows/ci.yml Co-authored-by: Joshua Liebow-Feeser <[email protected]> --------- Co-authored-by: Joshua Liebow-Feeser <[email protected]>
This closes #340. I tried putting the yaml in the workflow folder for the new cache job but it wasn't able to find it, so I made it an action.