-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 0.33.0 is incorrectly marked as supporting Python2.7 #1154
Comments
Maybe yank |
@bwendling , thoughts here? |
I'm not sure what's the best course of action. If we want to replace it, then we should go with |
Replacing it with 0.33.1 as a py3 only release will still cause 0.33.0 to be incorrectly resolved as the "final" py2 release. My understanding is that "yanked" is just metadata, so that yapf>=0.32.0 will resolve to 0.32.0 on py2. I would suspect that pinned 0.33.0 in peoples' requirements.txt and lock files would still install 0.33.0 even if it is yanked. Need someone whose actually worked with yanking and/or testing on Test PyPi as part of this. https://peps.python.org/pep-0592/ Pep on yanking |
To clarify, my suggestion does not involve deleting the release from PYPI but to mark the release as yanked. |
I would mark 0.33.0 and 0.40.0 as yanked, testing in Test PyPi first. |
SGTM. I went ahead and marked them as "yanked". |
@bwendling I've confirmed that 0.32.0 is now the latest version that resolves.
|
Thank you for the fixes! |
Not sure what the fix is here, but I realized today that version 0.33.0 does not support python2.7 but was inadvertently uploaded to PyPi as such. The last version that supported python2.7 was 0.32.0 and a fresh installation attempt of yapf when using python2.7 should not resolve to any newer version.
The text was updated successfully, but these errors were encountered: