Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with firefox on macos again #163

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Test with firefox on macos again #163

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
32a00df
Try to find where firefox is installed
jonasfj Oct 22, 2024
8583352
Update test.yml
jonasfj Oct 22, 2024
37f65ff
Manually specify firefox location for package:test on macos
jonasfj Oct 22, 2024
132dd2c
Merge branch 'master' into fix-firefox-macos
jonasfj Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,14 @@ jobs:
# --driver=test_driver/integration_test.dart \
# --target=integration_test/webcrypto_test.dart \
# -d chrome
# TODO: Enable firefox testing on MacOS when it works
- run: flutter pub run test -p vm,chrome
- uses: browser-actions/setup-firefox@v1
- name: flutter pub run test -p vm,chrome,firefox
shell: bash
# Remove FIREFOX_EXECUTABLE override when flutter upgrades past package:test 1.25.8
# Issue is fixed in https://github.com/dart-lang/test/pull/2276
run: |
export FIREFOX_EXECUTABLE="$(which firefox)"
flutter pub run test -p vm,chrome,firefox
macos-15:
name: webcrypto on macOS 15 desktop / Chrome
runs-on: macos-15 # Test with xcode 16
Expand All @@ -98,8 +104,14 @@ jobs:
- run: flutter test integration_test/webcrypto_test.dart -d macos
working-directory: ./example
# TODO: Enable chromedriver testing on MacOS when it works reliably
# TODO: Enable firefox testing on MacOS when it works
- run: flutter pub run test -p vm,chrome
- uses: browser-actions/setup-firefox@v1
- name: flutter pub run test -p vm,chrome,firefox
shell: bash
# Remove FIREFOX_EXECUTABLE override when flutter upgrades past package:test 1.25.8
# Issue is fixed in https://github.com/dart-lang/test/pull/2276
run: |
export FIREFOX_EXECUTABLE="$(which firefox)"
flutter pub run test -p vm,chrome,firefox
windows:
name: webcrypto on Windows desktop / Chrome / Firefox
runs-on: windows-latest
Expand Down
Loading