Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade etcd to 3.4.7 #2089

Closed
wants to merge 6 commits into from
Closed

Upgrade etcd to 3.4.7 #2089

wants to merge 6 commits into from

Conversation

gdbelvin
Copy link
Contributor

@gdbelvin gdbelvin commented Apr 24, 2020

Resolves CVE-2018-1098 CVE-2018-1099. etcd-io/etcd#10480

The version number go.etcd.io/etcd v0.0.0-20200401174654-e694b7bb0875 was calculated with the following script, as suggested in etcd-io/etcd#11154

git clone --branch v3.4.7 https://github.com/etcd-io/etcd.git
cd etcd
echo -n v0.0.0-
TZ=UTC git --no-pager show \
  --quiet \
  --abbrev=12 \
  --date='format-local:%Y%m%d%H%M%S' \
  --format="%cd-%h"

```
git clone --branch v3.4.7 https://github.com/etcd-io/etcd.git
cd etcd
echo -n v0.0.0-
TZ=UTC git --no-pager show \
  --quiet \
  --abbrev=12 \
  --date='format-local:%Y%m%d%H%M%S' \
  --format="%cd-%h"
```
@gdbelvin gdbelvin added the bug label Apr 24, 2020
@gdbelvin gdbelvin requested a review from a team as a code owner April 24, 2020 16:47
@gdbelvin gdbelvin requested a review from Mercurrent April 24, 2020 16:47
@gdbelvin gdbelvin requested a review from NatalieDoduc April 24, 2020 16:50
Fix unsafe pointer conversions caught by Go 1.14 checkptr
@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #2089 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2089      +/-   ##
==========================================
- Coverage   58.94%   58.92%   -0.03%     
==========================================
  Files         115      115              
  Lines        9778     9778              
==========================================
- Hits         5764     5762       -2     
- Misses       3511     3513       +2     
  Partials      503      503              
Impacted Files Coverage Δ
quota/etcd/etcdqm/etcdqm.go 92.59% <ø> (ø)
quota/etcd/quotaapi/quota_server.go 93.79% <ø> (ø)
quota/etcd/storage/quota_storage.go 84.15% <ø> (ø)
util/election2/etcd/election.go 75.00% <ø> (ø)
log/operation_manager.go 86.97% <0.00%> (-0.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9a46df...0b2bbee. Read the comment docs.

bump travis 2
@gdbelvin
Copy link
Contributor Author

@googlebot recheck

@gdbelvin gdbelvin closed this Apr 24, 2020
@gdbelvin gdbelvin deleted the etcd branch April 24, 2020 19:58
@gdbelvin gdbelvin restored the etcd branch April 24, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants