Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #87
I was able to run
shaderc-rs
on the Android app with dynamically linked shaderc that was built with thendk-build
tool insidebuild/shaderc/android_test
folder with the following command:Then I provide the path to the libs folder as
SHADERC_LIB_DIR
. I'm sure that this is not a good way to make it work but still - it works and I want to hear any feedback on how to make it right.Also, there's still not possible to build it with the
CARGO_FEATURE_BUILD_FROM_SOURCE
and without PITA while building it withndk-build
by yourself. Should I addndk-build
tobuild.rs
or there some way to do it withninja
?