Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Android support #88

Closed
wants to merge 2 commits into from
Closed

Initial Android support #88

wants to merge 2 commits into from

Conversation

enfipy
Copy link

@enfipy enfipy commented Oct 18, 2020

Closes #87

I was able to run shaderc-rs on the Android app with dynamically linked shaderc that was built with the ndk-build tool inside build/shaderc/android_test folder with the following command:

ndk-build APP_BUILD_SCRIPT=Android.mk SPVTOOLS_LOCAL_PATH=../third_party/spirv-tools SPVHEADERS_LOCAL_PATH=../third_party/spirv-headers APP_STL:=c++_shared APP_ABI=all -j

Then I provide the path to the libs folder as SHADERC_LIB_DIR. I'm sure that this is not a good way to make it work but still - it works and I want to hear any feedback on how to make it right.

Also, there's still not possible to build it with the CARGO_FEATURE_BUILD_FROM_SOURCE and without PITA while building it with ndk-build by yourself. Should I add ndk-build to build.rs or there some way to do it with ninja?

@google-cla
Copy link

google-cla bot commented Oct 18, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@antiagainst
Copy link
Collaborator

Thanks for adding this!! Could you rebase first? The buildbots failure is fixed at top of the tree. I'll take a look later. :)

@enfipy enfipy closed this Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lack of Android support
3 participants