Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: silence deprecation warnings that appear with gcc 8 #63

Merged
merged 1 commit into from
May 15, 2019
Merged

chore: silence deprecation warnings that appear with gcc 8 #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@
"sources": [
"bindings/profiler.cc",
],
"include_dirs": [ "<!(node -e \"require('nan')\")" ]
"include_dirs": [ "<!(node -e \"require('nan')\")" ],
# TODO(#62): The following line suppresses compliation warnings
# originating from v8 and node that appear when gcc 8 is used.
# Once the warnings are fixed upstream, this line should be removed.
"cflags": [ "-Wno-cast-function-type" ]
},
{
"target_name": "action_after_build",
Expand Down