Fixes issue with framing a quantized GLTF #2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
elalish
reviewed
Jun 9, 2021
donmccurdy
reviewed
Jun 12, 2021
| */ | ||
| export const getNormalizedComponentScale = | ||
| (buffer: BufferAttribute|InterleavedBufferAttribute) => { | ||
| const array: ArrayLike<number> = buffer.array; |
There was a problem hiding this comment.
May need to check buffer.normalized here - the array could be Uint8Array but not normalized.
|
No problem, I can add this check. Do you per-chance know of a model that
falls into this category of having UInt8Array of position data (for
instance) but is not normalized?
…On Sat, Jun 12, 2021 at 1:24 PM Don McCurdy ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In packages/model-viewer/src/three-components/ModelUtils.ts
<#2463 (comment)>:
>
+
+/**
+ * Gets a scale value to perform inverse quantization of a vertex value
+ * Reference:
+ * https://github.com/KhronosGroup/glTF/tree/master/extensions/2.0/Khronos/KHR_mesh_quantization#encoding-quantized-data
+ * @param buffer A gltf vertex buffer
+ * @returns A scale value based on KHR_mesh_quantization or 1 if the buffer is
+ * not quantized.
+ */
+export const getNormalizedComponentScale =
+ (buffer: BufferAttribute|InterleavedBufferAttribute) => {
+ const array: ArrayLike<number> = buffer.array;
May need to check buffer.normalized here - the array could be Uint8Array
but not normalized.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#2463 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZY3MTIVSQHTPBTNGXJJXTTSO7BNANCNFSM46K53ZQQ>
.
|
|
Sure, gltfpack produces models like that — here's an aggressively quantized duck for example: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve framing/rendering issue with quantized models.
fixes #2450
Reference Issue