Missed emul classes for java 9-11 #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See earlier review at https://gwt-review.googlesource.com/c/gwt/+/21501. Build changes get us ready for missing Java 10 and 11 emulation as well. Partial #9547 (cherry picked from commit 3250dca76051493f17c2a39eca216cd55c7153fc)
Partial #9547 (cherry picked from commit 9b9e888bfc5c8991425da65b0e2f12577d0ac638)
Partial #9547 (cherry picked from commit a9aeadd1382da173389d5313d2d24f8cf38007f5)
Partial #9547 Co-authored-by: Alexey Abashev <[email protected]> (cherry picked from commit d73d095eabcf18d565ee9eebacdaa2895ae77c52)
Partial #9547 (cherry picked from commit 1ca97c479868dd40219d4fe64a25823592f820af)
Partial #9547 (cherry picked from commit be374733d88677f0a2c038c994c304a60d30d30d)
Add missing `not` method to Predicate to be java 11 compatible. Partial #9547 (cherry picked from commit c4befe7d0d402118f79be783d2cbcbb061054f04)
Fixes #9547 (cherry picked from commit c5d74f1734bd58a7e3e797a6cc8ca89e2cd7134c)
Java 10 added copyOf static factory methods to produce immutable List/Set/Map instances that contain no nulls. Follow-up #9547 (cherry picked from commit f05b257fb480707aac412b227907a0383c913e70)
|
The first commit in this series incorporates changes from the review at https://gwt-review.googlesource.com/c/gwt/+/21501. |
|
Thanks for the patch. Yes it would definitely help if you separate it into smaller parts. |
Great, then I will make PRs as you merge them. see: #223 |
|
see #223 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large PR. If it's more convenient for you to work with it in parts, let me know, and I will make the PRs one by one.