Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve scrollable screenshots #2140

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Improve scrollable screenshots #2140

merged 2 commits into from
Mar 18, 2024

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Mar 18, 2024 •
edited
Loading

WHAT

Improve scrollable screenshots

WHY

Use repeated touches so SLC state doesn't get passed around.

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@yschimke yschimke requested a review from BowerSteve March 18, 2024 14:34
@yschimke yschimke closed this Mar 18, 2024
@yschimke yschimke reopened this Mar 18, 2024
@yschimke
Copy link
Collaborator Author

@BowerSteve I won't wait for you, it's mostly screenshot tests.

@yschimke yschimke merged commit 536a255 into google:main Mar 18, 2024
4 checks passed
@yschimke yschimke deleted the screenshot_improvements branch March 25, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BowerSteve BowerSteve BowerSteve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yschimke @BowerSteve