Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional padding at end of SLC #2045

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Feb 19, 2024

WHAT

Default to an additional 10dp at end of responsive() to avoid clipping.
Can be overridden.

WHY

Clipping of a tall Card may lead to apps getting rejected.

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

Copy link
Collaborator

@BowerSteve BowerSteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yschimke yschimke merged commit 9eb5ea3 into google:main Feb 19, 2024
4 checks passed
yschimke added a commit to yschimke/horologist that referenced this pull request Feb 20, 2024
yschimke added a commit that referenced this pull request Feb 20, 2024
yschimke added a commit that referenced this pull request Feb 20, 2024
yschimke added a commit that referenced this pull request Feb 20, 2024
yschimke added a commit that referenced this pull request Feb 20, 2024
* Additional padding at end of list (#2045)

(cherry picked from commit 9eb5ea3)

* 🤖 Updates screenshots

---------

Co-authored-by: yschimke <[email protected]>
@yschimke yschimke deleted the safe_padding branch March 14, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants