Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onClick A11y #2040

Merged
merged 5 commits into from
Feb 19, 2024
Merged

Fix onClick A11y #2040

merged 5 commits into from
Feb 19, 2024

Conversation

yschimke
Copy link
Collaborator

WHAT

set semantics labels when we override

WHY

fixes #2039

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@yschimke yschimke requested review from luizgrp and Kpeved February 19, 2024 10:03
@yschimke yschimke closed this Feb 19, 2024
@yschimke yschimke reopened this Feb 19, 2024
@yschimke yschimke closed this Feb 19, 2024
@yschimke yschimke reopened this Feb 19, 2024
@yschimke yschimke merged commit 8851577 into google:main Feb 19, 2024
8 of 10 checks passed
yschimke added a commit to yschimke/horologist that referenced this pull request Feb 20, 2024
(cherry picked from commit 8851577)
yschimke added a commit that referenced this pull request Feb 20, 2024
(cherry picked from commit 8851577)
@yschimke yschimke deleted the fix_onclick branch March 14, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chip doesn't set onClick label
2 participants