Docker setup 102 #18
Docker setup 102 #18
Conversation
| @@ -1,4 +1,4 @@ | |||
| FROM haskell:latest | |||
| FROM haskell:8 | |||
There was a problem hiding this comment.
Clarifying question: why don't we pull from the latest tag?
There was a problem hiding this comment.
I noticed that there is a deprecation warning on cabal when installing dependencies using cabal install <pkg> so I figured locking the version would make sure people using this repo for learning haskell would never have a failing docker build in case haskell:9 came out, for example
There was a problem hiding this comment.
That's perfect. Let's also add a comment for this so that when future changes upgrade tag we know to check that the warnings are gone. Thank you
| RUN cabal update && cabal install random | ||
| WORKDIR /codelab | ||
|
|
||
| COPY . . |
There was a problem hiding this comment.
Isn't this a no-op? (I'm no Docker expert, so maybe I'm missing something)
There was a problem hiding this comment.
COPY <src> <dest>
This copies the entire directory from the codelab folder of this repo in to the current folder of the container, which in this case is /codelab
See COPY for more https://docs.docker.com/engine/reference/builder/#copy
There was a problem hiding this comment.
Can you add a short comment for this, please? To not trip future readers.
Thank you for the clarification
shaneikennedy
force-pushed
the
docker-setup-102
branch
from
dba10b1 to
df896d0
Compare
|
Hey @mihaimaruseac does anything else need to be done here? |
|
Sorry, didn't get new notifications and missed it. Thanks for the ping and the PR |
👋 Hello again,
Last week I PR'd some commits that added a basic docker setup and a readme with instructions for how to get started on the 101 codelab, and this is a similar PR for 102.
Let me know if you have any questions or suggestions for improvements 👍