Prepare for Bazel incompatible changes #2381
Conversation
Fixes googletest for upcoming `--incompatible_load_cc_rules_from_bzl` (bazelbuild/bazel#8743) and `--incompatible_load_python_rules_from_bzl` (bazelbuild/bazel#9006). This change was automatically generated with `buildifier -lint=fix -warnings=all $(find . -name "BUILD" -o -name "BUILD.bazel" -o -name "*.bzl")`.
| @@ -155,11 +157,11 @@ cc_test( | |||
| "googletest/samples/sample7_unittest.cc", | |||
| "googletest/samples/sample8_unittest.cc", | |||
| ], | |||
| linkstatic = 0, | |||
There was a problem hiding this comment.
Looks like there is no good reason to move this line from previous location.Could you please limit the changes to the actual factual changes to remove the noise.
| @@ -81,6 +83,10 @@ cc_library( | |||
| ":has_absl": ["GTEST_HAS_ABSL=1"], | |||
| "//conditions:default": [], | |||
| }), | |||
| features = select({ | |||
There was a problem hiding this comment.
Looks like there is no good reason to move this line from previous location.Could you please limit the changes to the actual factual changes to remove the noise.
There was a problem hiding this comment.
buildifier automatically formats BUILD files in the canonical way when it applies fixes, so the new location is the correct one. I can revert to the old format manually, but I don't think it adds a lot of noise, and the next person editing the BUILD file will likely do the same changes again.
(Dito other comments)
| features = select({ | ||
| ":windows": ["windows_export_all_symbols"], | ||
| "//conditions:default": [], | ||
| }) | ||
| }), | ||
| deps = [":gtest"], |
There was a problem hiding this comment.
Looks like there is no good reason to move this line from previous location.Could you please limit the changes to the actual factual changes to remove the noise.
| @@ -81,6 +83,10 @@ cc_library( | |||
| ":has_absl": ["GTEST_HAS_ABSL=1"], | |||
| "//conditions:default": [], | |||
| }), | |||
| features = select({ | |||
There was a problem hiding this comment.
buildifier automatically formats BUILD files in the canonical way when it applies fixes, so the new location is the correct one. I can revert to the old format manually, but I don't think it adds a lot of noise, and the next person editing the BUILD file will likely do the same changes again.
(Dito other comments)
- 263602063 Import OSS PR #2381 https://github.com/google/googletest/... by misterg <[email protected]> PiperOrigin-RevId: 263602063
- 263623083 Import OSS PR #2381 https://github.com/google/googletest/... by misterg <[email protected]> PiperOrigin-RevId: 263623083
PiperOrigin-RevId: 264186624
PiperOrigin-RevId: 264186624
Fixes googletest for upcoming
--incompatible_load_cc_rules_from_bzl(bazelbuild/bazel#8743) and--incompatible_load_python_rules_from_bzl(bazelbuild/bazel#9006).This change was automatically generated with
buildifier -lint=fix -warnings=all $(find . -name "BUILD" -o -name "BUILD.bazel" -o -name "*.bzl").