Exception formatting switch expressions #477
Comments
copybara-service bot
pushed a commit
that referenced
this issue
May 9, 2020
`throws` statements are allows to occur in non-block expression switch cases, which was causing the trailing `;` to be printed twice. Fixes #477 PiperOrigin-RevId: 310735686
copybara-service bot
pushed a commit
that referenced
this issue
May 11, 2020
`throws` statements are allows to occur in non-block expression switch cases, which was causing the trailing `;` to be printed twice. Fixes #477 PiperOrigin-RevId: 310735686
ghost
mentioned this issue
|
This is a long standing issue that prevents us from using switch expressions. When will you finally release the fix? |
|
FYI fix still not available (intellij plugin 1.8.0.1, gradle spotless plugin 5.1.2). Any ETA pls? |
|
@tbroyer thanks a lot Thomas! any hint on when the jIDEA plugin could be pushed as well? |
|
I still get an exception when I activate the option
|
|
@krusche do you have a repro? can you share the contents of |
|
I'm also still getting the error as @krusche when using edit: According to https://github.com/diffplug/spotless/blob/main/lib/src/main/java/com/diffplug/spotless/java/RemoveUnusedImportsStep.java and https://github.com/diffplug/spotless/blob/main/lib/src/main/java/com/diffplug/spotless/java/GoogleJavaFormatStep.java, |
|
The spotless bug referenced above was fixed in |
robfig
pushed a commit
to yext/yext-java-format
that referenced
this issue
Dec 17, 2020
* Update outdated Javadoc links Fixes google#409 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=286092096 * Fix a crash on c-style arrays in parameters Fixes google#374 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=286467734 * Add SBT plugin to readme Fixes google#391 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=286493206 * annotation/parameterless annotation Parameterless annotations aren't necessarily marker annotations. All we can tell about a use of an annotation is that it's parameterless, and that's how 4.8.5 is specified. Related: google#360 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=286650854 * Tell maven-javadoc-plugin to target JDK 8 This unbreaks `mvn install` on AdoptOpenJDK 11. Presumably it unbreaks on all JDKs >= 11. Fixes google#429 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=288016119 * Remove trailing tabs from comments to make behavior idempotent. Fixes google#422, fixes google#423 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=288364171 * Migrate from JSR-305 to the Checker Framework annotations this is tangentially related to Java 11 preparedness. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=300822964 * Add Java 11 regression tests ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=301273002 * Use the built-in JDK 11 javac instead of relying on the shaded/vendored version. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=301645476 * Increase minimum required JDK version to 11 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=301832060 * Use the default / latest supported language level Previously the shaded javac was defaulting to Java 8, which we needed to override to support Java 9. Now that we're using stock JDK 11 this is unnecessary. Also explicitly support `var`, instead of relying on it getting parsed as an actual type name. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=302105420 * Preserve tabular arguments for mixed sign numeric lists. Treats unary minus literals (eg -4.0) as their underlying type when checking if all elements in a tabular list are of the same Tree.Kind. Fixes google#400, google#406 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=303137504 * Add initial support for Java 14 language features ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=303367644 * Make re-parsing of var more robust to support uses of `var` as an identifier, with and without a type, e.g. in `var -> { ... }` and `int var x = 42`; and uses of `var ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=307693554 * Update the open-source google-java-format plugin for 2020.1. I couldn't find any good way to make this backwards compatible. Oh well. FYI, It looks like in 2020.1, we can probably actually use the ExternalFormatProcessor extension point instead of doing all this hacky nonsense... they added a #format(PsiFile, TextRange) method you can override. But I'll leave that for later because 2020.1 is out now and people are mad. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=308647308 * Fix formatting of records without an explicit constructor Fixes google#460 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=308658958 * Support `var` in enhanced for loops Fixes google#463 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=308891540 * Minor Javadoc improvement. PiperOrigin-RevId: 309329483 * Fix javadoc syntax Fix javadoc syntax by wrap `<` into an inline code block. ``` [WARNING] ...\google-java-format\core\src\main\java\com\google\googlejavaformat\java\JavaInputAstVisitor.java:2577: warning - invalid usage of tag < ``` Fixes google#454 COPYBARA_INTEGRATE_REVIEW=google#454 from sormuras:patch-1 f5583c7 PiperOrigin-RevId: 309364827 * Pre-release javadoc fixes PiperOrigin-RevId: 309456095 * Increment versions for 1.8 release PiperOrigin-RevId: 309467646 * Fix a crash in expression switches `throws` statements are allows to occur in non-block expression switch cases, which was causing the trailing `;` to be printed twice. Fixes google#477 PiperOrigin-RevId: 310974906 * Split up the string "M" + "OE:(begin|end)_intracomment_stripping," as the full string will trigger stripping under Copybara. Also, avoid reference to an internal link shortener, as we are making references to it an error. Looking to the future: When we migrate to use proper Copybara stripping directives, we could consider removing support for the old directives. Then the problem would mostly go away. However, we might end up having the same problem with Copybara directives when google-java-format's strings and method names start mentioning *them*. PiperOrigin-RevId: 311344956 * Addition of a third party: Github Actions - Add the possibility of formatting your code from Github directly (taking all the events of Github Actions) - Addition of the word "old" for the eclipse plugin, since it is 1.6 release Fixes google#487 COPYBARA_INTEGRATE_REVIEW=google#487 from av1m:master 351b737 PiperOrigin-RevId: 313312689 * Java 14 integration tests PiperOrigin-RevId: 314566781 * Add support for yield statement Implement visitYield. Fixes google#489 from ntkoopman:yield b46d1f0 COPYBARA_INTEGRATE_REVIEW=google#489 PiperOrigin-RevId: 314633394 * Support --skip-removing-unused-imports in google-java-format-diff.py Fixes google#495 COPYBARA_INTEGRATE_REVIEW=google#495 from taesu82:patch-1 91e32d4 PiperOrigin-RevId: 315560436 * Update the IDEA plugin to use google-java-format 1.8. PiperOrigin-RevId: 318495968 * Add missing license headers. PiperOrigin-RevId: 320733285 * Disable Appveyor builds on branches. Our account for Appveyor allows only 1 concurrent build. Our current Appveyor config builds every commit to a PR twice -- once as the PR and once as the branch. This CL updates our Appveyor config to disable builds on branches, so we get only one build per PR commit. PiperOrigin-RevId: 320734870 * Fix the google-java-format IDEA plugin for 2020.2 IDEs. PiperOrigin-RevId: 320945302 * Update links to Spotless' new documentation layout Also included the Spotless maven plugin (2+ years old, but not well marketed) Fixes google#509 COPYBARA_INTEGRATE_REVIEW=google#509 from nedtwigg:patch-2 546c758 PiperOrigin-RevId: 322832707 * Bump versions to 1.9 PiperOrigin-RevId: 328160170 * Increment versions after 1.10 release PiperOrigin-RevId: 328214914 * Bump checker-qual from 2.0.0 to 3.6.1 Fixes google#519 COPYBARA_INTEGRATE_REVIEW=google#519 from mernst:checker-qual-361 ca54cb9 PiperOrigin-RevId: 331830590 * Update the IntelliJ plugin to google-java-format 1.9. PiperOrigin-RevId: 332323928 * Upgrade junit dependency to 4.13.1 PiperOrigin-RevId: 336966883 * Tolerate extra semi-colons in import lists even if they're own their own line (which g-j-f does if it runs with import cleanup disabled). PiperOrigin-RevId: 337192414 * Move import ordering tests out of the AOSP section follow-up to google@b769e81 PiperOrigin-RevId: 337511552 * Remove typo period in flags documentation. I *think* they are typoes? Apologies if this is intended. PiperOrigin-RevId: 343547804 * Introduce GitHub Actions based CI workflow This PR introduces a CI workflow using GitHub Actions and removes the Travis CI configuration file. Find new workflow runs for this PR here: https://github.com/sormuras/google-java-format/actions #### TODO - [x] Email [Notifications](https://docs.github.com/en/free-pro-team@latest/github/managing-subscriptions-and-notifications-on-github/configuring-notifications) -- register `[email protected]` as a watcher or let each interested use register themself? - [ ] Test publish snapshot job on `google:master` -- after storing credential [secrets](https://github.com/google/google-java-format/settings/secrets/actions). - [ ] Remove AppVeyor [integration](https://github.com/google/google-java-format/settings/installations) and delete `appveyor.yml` configuration file. Closes google#543 Fixes google#544 COPYBARA_INTEGRATE_REVIEW=google#544 from sormuras:github-action a689f62 PiperOrigin-RevId: 344280060 * Check build with JDK 16-ea Addresses google#538 (comment) Fixes google#548 COPYBARA_INTEGRATE_REVIEW=google#548 from sormuras:jdk-ea 0ee3f7c PiperOrigin-RevId: 344818484 * Fix GitHub Actions-based snapshot deployment Fixes google#547 PiperOrigin-RevId: 344903246 * Delete google-java-format appveyor and travis configs PiperOrigin-RevId: 345300707 * Miscellaneous cleanups Startblock: cl-status copybara contains unknown commit in live PiperOrigin-RevId: 345718768 * Prepare google-java-format for JDK 16 ea * Work around change to tokenization in JDK-8254073 * Access refactored expression pattern getters reflectively * Relax a check on a diagnostic whose position changed PiperOrigin-RevId: 347318664 Co-authored-by: Anthony Vanelverdinghe <[email protected]> Co-authored-by: cushon <[email protected]> Co-authored-by: Ben McCann <[email protected]> Co-authored-by: Carmi Grushko <[email protected]> Co-authored-by: Eckert, Alexander <[email protected]> Co-authored-by: Andrew Reid <[email protected]> Co-authored-by: plumpy <[email protected]> Co-authored-by: google-java-format Team <[email protected]> Co-authored-by: Christian Stein <[email protected]> Co-authored-by: cpovirk <[email protected]> Co-authored-by: Avi Mimoun <[email protected]> Co-authored-by: Tim Koopman <[email protected]> Co-authored-by: taesu82.lee <[email protected]> Co-authored-by: google-java-format Team <[email protected]> Co-authored-by: Eddie Aftandilian <[email protected]> Co-authored-by: Ned Twigg <[email protected]> Co-authored-by: Michael Ernst <[email protected]>
|
I still face this issue with Switch expressions. I use the latest |
|
Maybe you are running Gradle on an older JVM? Gradle allows you to specify which JVM to use for running javac, etc, but that does not work with Spotless, we use whichever JVM you start gradle with, and that will determine which language-level that google-java-format will work with. |
|
When I used Java 16 with Gradle, I get the following error. It's not clear from the trace what's the problem in the file. |
|
This is expected to fail on Java 11. On Java 16, you'll need this workaround: diffplug/spotless#834 (comment) |
https://github.com/google/google-java-format#jdk-16
|
FYI the workaround for CLI usage is documented here: https://github.com/google/google-java-format/releases/tag/v1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Formatting this code:
Produces this exception: https://pastebin.com/yQ1kt8mh
Formatting this code:
Produces this exception: https://pastebin.com/SEC77wYT
I am using version
1.8through spotless java version3.29.0(latest) and running on JDK 14.The text was updated successfully, but these errors were encountered: