Support for taking a Perfetto trace in GAPIS #2709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- drop the magic window size constant and simply use Perfetto's default. - Remove a TODO comment
This lays the foundation to support taking multiple kinds of traces. Clients should query the server for what types of traces are supported. Currently GAPIS only returns the Graphics trace type.
pmuetschard
force-pushed
the
perfetto_trace
branch
from
3d8bc1c to
50e3554
Compare
AWoloszyn
reviewed
Apr 9, 2019
gapis/perfetto/trace.go
Outdated
| const ( | ||
| // perfettoTraceFile is the location on the device where we'll ask Perfetto | ||
| // to store the trace data while tracing. | ||
| perfettoTraceFile = "/data/misc/perfetto-traces/gapis-trace" |
There was a problem hiding this comment.
This should probably be attached to the device. Especially if we want to be able to take perfetto traces elsewhere.
There was a problem hiding this comment.
I've moved this into an android subdirectory. PTAL
And allow the UI (hidden via a flag) to take a Perfetto trace.
pmuetschard
force-pushed
the
perfetto_trace
branch
from
50e3554 to
d9f1149
Compare
AWoloszyn
approved these changes
Apr 10, 2019
|
Awesome thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes the fixes asked for in #2696, which I accidentally dropped in excitement when the build finally went green.