Handle a missed GL_HALF_FLOAT vs GL_HALF_FLOAT_OES case. #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`GL_HALF_FLOAT` does not have the same value as `GL_HALF_FLOAT_OES`. We need to handle both everywhere, but missed it in `GetSizedFormatFromTuple`. Fixes google#2603
pau-baiget
reviewed
Mar 4, 2019
| @if(Extension.GL_OES_texture_float) | ||
| case GL_FLOAT: GL_LUMINANCE32F_EXT | ||
| default: GL_NONE | ||
| } | ||
| case GL_ALPHA: switch type { | ||
| case GL_UNSIGNED_BYTE: GL_ALPHA8_EXT | ||
| @if(Extension.GL_OES_texture_half_float) | ||
| case GL_HALF_FLOAT_OES: GL_ALPHA16F_EXT | ||
| case GL_HALF_FLOAT, GL_HALF_FLOAT_OES: GL_ALPHA16F_EXT |
There was a problem hiding this comment.
Doesn't CheckTextureDataType (line 503) need update as well?
There was a problem hiding this comment.
No. that one already handles both constants. Make sure to read through the whole function to notice.
AWoloszyn
approved these changes
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GL_HALF_FLOATdoes not have the same value asGL_HALF_FLOAT_OES. We need to handle both everywhere, but missed it inGetSizedFormatFromTuple.Fixes #2603