Vulkan: Support of VK_KHR_maintenance2 extension #2503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note the dependency change introduced by `VkInputAttachmentAspectRefernceKHR` is not handled yet. Following Note and TODO added as comments The intput attachment aspect info is only cached but not used for now, so the dependency can be wrong as a draw call may depends on just one aspect of a depth stencil image, as specified in the input attachment aspect info, while GAPID will still treat both aspects as dependees. TODO: Once the CL that enables us getting used descriptors from shader is in, we can pull `input_attachment_index` from the information of the used descriptors then use the input attachment aspect info to fix the dependency.
AWoloszyn
approved these changes
Dec 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note the dependency change introduced by
VkInputAttachmentAspectRefernceKHRis not handled yet.Following Note and TODO added as comments
The intput attachment aspect info is only cached but not used for now, so the
dependency can be wrong as a draw call may depends on just one aspect of a
depth stencil image, as specified in the input attachment aspect info, while
GAPID will still treat both aspects as dependees.
TODO: Once the CL that enables us getting used descriptors from shader is in,
we can pull
input_attachment_indexfrom the information of the useddescriptors then use the input attachment aspect info to fix the dependency.