A few more small fixes around images and descriptor sets. #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is valid to call VkAllocateDescriptorSets even in the cases where it will fail. (1025 sets in a 1024 set pool). Clean up some warnings that the validation layers were throwing from the state rebuilder.
ben-clayton
approved these changes
Jul 25, 2018
| @@ -2405,11 +2405,12 @@ func (sb *stateBuilder) createDescriptorPoolAndAllocateDescriptorSets(dp Descrip | |||
| descSetHandles := make([]VkDescriptorSet, 0, dp.DescriptorSets().Len()) | |||
| descSetLayoutHandles := make([]VkDescriptorSetLayout, 0, dp.DescriptorSets().Len()) | |||
| for vkDescSet, descSetObj := range dp.DescriptorSets().All() { | |||
| if sb.s.DescriptorSets().Contains(vkDescSet) { | |||
| if vkDescSet != VkDescriptorSet(0) && sb.s.DescriptorSets().Contains(vkDescSet) && sb.s.DescriptorSetLayouts().Contains(descSetObj.Layout().VulkanHandle()) { | |||
There was a problem hiding this comment.
Nit: no need to cast literals. VkDescriptorSet(0) becomes 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is valid to call VkAllocateDescriptorSets even in the cases
where it will fail. (1025 sets in a 1024 set pool).
Clean up some warnings that the validation layers were throwing
from the state rebuilder.