fix: Fix bug that caused text to be selected when long-pressing in the workspace on a touch device. #8670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Proposed Changes
This PR sets
user-select: none;on the entire injection div, which prevents users from selecting text. We had already had this in place on block text, menus, and toolbox categories, but since e.g. the workspace and blocks themselves did not, long-pressing those items on mobile would also select text (often outside of Blockly) in addition to presenting the context menu. I repro'd this and confirmed the fix on an iPad, but I strongly suspect the two linked issues are the same thing; if folks with an Android and/or ChromeOS touchscreen device could confirm this also resolves the issue there, that would be great, but I'm nearly certain this resolves the problem there as well.Note that this does not prevent selecting text in text fields, either in blocks or comments. I verified this across Chrome, Safari and Firefox.