fix: dragging blocks by shadows to delete #8138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcallen
approved these changes
May 17, 2024
1 task
BeksOmega
added a commit
to BeksOmega/blockly
that referenced
this pull request
May 22, 2024
This reverts commit 3fd7492.
BeksOmega
added a commit
that referenced
this pull request
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8137
Proposed Changes
Reverts the old code for dragging shadows, which delegated to parents, and instead just select the parent from the beginning.
Click events still get fired on the shadow though because that's based on the start blocks not the selection.
Test Coverage
Manually tested dragging and deleting by shadows.
Documentation
N/A
Additional Information
N/A