fix: correct dropdown arrow placement for Thrasos on Safari #8017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-fenichel
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #7890
Proposed Changes
Ensure that the dominant baseline for the arrow symbol on dropdown fields is 'center'. The exception is when a field's text element's dominant baseline should not be centered. Previously this was true for certain browsers (IE and Edge), but now it's only true for the Geras renderer. (
blockly/core/renderers/geras/constants.ts
Line 15 in 9e05d69
Screenshots are of the Advanced Playground, renderer set to Thrasos on Safari. No regressions found for other renderers or other browsers.
Before:
After:
Reason for Changes
When using the Thrasos renderer on Safari, all arrows in dropdown fields appear too high. This is evidently because Safari does not inherit the property dominant-baseline: "central" from the parent element.
Test Coverage
No test have been added.
Documentation
I don't believe this warrants any updates to documentation.
Additional Information