fix: compatibility with scroll plugin #8016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
commented
Apr 8, 2024
| @@ -1139,6 +1139,11 @@ export class Gesture { | |||
|
|
|||
| /* End helper functions defining types of clicks. */ | |||
|
|
|||
| /** Returns the current dragger if the gesture is a drag. */ | |||
| getCurrentDragger(): WorkspaceDragger | IDragger | null { | |||
There was a problem hiding this comment.
I thought we weren't using this so I deleted it :P Turns out the scroll-options plugin needs it.
1 task
rachel-fenichel
approved these changes
Apr 8, 2024
johnnesky
pushed a commit
to johnnesky/blockly
that referenced
this pull request
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Work on google/blockly-samples#2317
Proposed Changes + Reasons
Fixes some problems that made it impossible to get the scroll-options plugin to work with the new system. (Mostly visibility issues).
Test Coverage
Tested with the upgraded plugin.
Documentation
N/A
Additional Information
N/A