chore!: delete old dragging infrastructure #7995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
breaking change
BeksOmega
force-pushed
the
chore/delete-old-drag
branch
from
a73e8a3 to
7d2be81
Compare
rachel-fenichel
approved these changes
Apr 4, 2024
johnnesky
pushed a commit
to johnnesky/blockly
that referenced
this pull request
Apr 13, 2024
github-actions
bot
added
breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #7900
Proposed Changes
Deletes the old blocks dragger and old interfaces, and remaining references to those interfaces.
Test Coverage
Build continues to build.
Documentation
N/A
Additional Information
N/A
Breaking changes / To fix
If you were creating a custom
IBlockDraggeryou should change this to either use a custom dragger, or a custom draggable instead.If you were referrencing the
BlockDraggerclass, you should instead reference the Dragger class, which you can retrieve from gesture.getCurrentDragger.