feat!: change gestures to look at selected when dragging #7991
Conversation
github-actions
bot
added
PR: feature
BeksOmega
changed the title
github-actions
bot
added
breaking change
core/block_svg.ts
Outdated
| @@ -241,37 +241,19 @@ export class BlockSvg | |||
| return this.style.colourTertiary; | |||
| } | |||
|
|
|||
| // TODO: Before merging, is it better to just remove these or to leave them | |||
There was a problem hiding this comment.
Actually we have to leave these so that the BlockSvg conforms to the ISelectable interface.
There was a problem hiding this comment.
Since you have to keep it, please add a description of the breaking change to the PR description (as I understanding, that block.select() and block.unselect() no longer fire events or update the workspace's selected value--they just update the block itself--and that devs need to call common.select to get the old behaviour.
There was a problem hiding this comment.
I'm gonna go through and update the PR descriptions in bulk before the release.
BeksOmega
force-pushed
the
feat/gestures-selected
branch
from
ba804c4 to
3163dc6
Compare
core/block_svg.ts
Outdated
| @@ -241,37 +241,19 @@ export class BlockSvg | |||
| return this.style.colourTertiary; | |||
| } | |||
|
|
|||
| // TODO: Before merging, is it better to just remove these or to leave them | |||
There was a problem hiding this comment.
Since you have to keep it, please add a description of the breaking change to the PR description (as I understanding, that block.select() and block.unselect() no longer fire events or update the workspace's selected value--they just update the block itself--and that devs need to call common.select to get the old behaviour.
* feat: change gestures to look at selected when dragging * chore: fix tests * chore: format * chore: PR comments
github-actions
bot
added
breaking change
The basics
The details
Resolves
Fixes N/A
Proposed Changes + reasons
Makes it so the gesture class looks at whatever is selected when it starts a drag. This will allow the multi select plugin to provide its own draggable for when multiple things are selected.
Test Coverage
Manually tested and everything seems to be working! But this could definitely use some hammering.
Documentation
N/A
Additional Information
N/A
Breaking changes / To fix
This reverses the responsibility of the
Blockly.common.setSelectedand thesomeElement.selectmethods. If you were callingselectorunselectyou should instead callBlockly.common.setSelected(some element)andBlockly.common.setSelected(null)respectively.