Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: comment icon interface re serialization #7964

Merged

Conversation

BeksOmega
Copy link
Collaborator

The basics

The details

Resolves

Fixes N/A

Proposed Changes

When writing up docs for how to override comment icons I realized that the interface didn't really deal with serialization, when it should. These edits remedy that.

Test Coverage

N/A

Documentation

This is for docs!

Additional Information

N/A

@github-actions github-actions bot added the PR: fix Fixes a bug label Mar 26, 2024
@BeksOmega BeksOmega marked this pull request as ready for review March 26, 2024 17:58
@BeksOmega BeksOmega requested a review from a team as a code owner March 26, 2024 17:58
@BeksOmega BeksOmega requested a review from NeilFraser March 26, 2024 17:58
@BeksOmega BeksOmega assigned maribethb and unassigned NeilFraser Apr 1, 2024
@BeksOmega BeksOmega requested review from maribethb and removed request for NeilFraser April 1, 2024 21:17
@BeksOmega BeksOmega merged commit 2fa6f5b into google:rc/v11.0.0 Apr 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants