fix: comment move and change events #7947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
force-pushed
the
fix/comment-other-events
branch
from
274462e to
68128cb
Compare
BeksOmega
force-pushed
the
fix/comment-other-events
branch
from
2f7ebcf to
a5da195
Compare
rachel-fenichel
approved these changes
Apr 3, 2024
johnnesky
pushed a commit
to johnnesky/blockly
that referenced
this pull request
Apr 13, 2024
* fix: comment move event * feat: add support for a drag reason * fix: comment change events * chore: add tests for move and change events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Work on #7909
Proposed Changes
Fixes the comment move and comment change events to be fired at the correct times and whatnot.
Test Coverage
All tests pass.
Manually tested undo and redo work correctly.
Documentation
N/A
Additional Information
N/A