Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modify Webpack sourcemap parameters to account for Windows path separators #2465

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

Varriount
Copy link
Contributor

The basics

The details

Proposed Changes

This PR modifies the Webpack configurations throughout the repository such that:

  • The regular expression used to determine which sourcemaps to load/look for works on Windows systems.
  • The regular expression used to determine which sourcemap parsing errors to ignore only covers paths containing the term "blockly"

Reason for Changes

Prior to this change, Blockly source maps wouldn't load on Windows systems, as Windows uses a backslash as a path separator, not a forward slash. The parsing error regex was modified as it occurred to me that it was overly broad, and might hide meaningful errors over the course of regular development.

@Varriount Varriount requested a review from a team as a code owner October 19, 2024 22:31
@Varriount Varriount requested review from rachel-fenichel and removed request for a team October 19, 2024 22:31
Copy link

conventional-commit-lint-gcf bot commented Oct 19, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Copy link

google-cla bot commented Oct 19, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Varriount Varriount changed the title Account for Windows path separators in Webpack configurations Modify Webpack sourcemap parameters to account for Windows path separators Oct 19, 2024
@Varriount Varriount changed the title Modify Webpack sourcemap parameters to account for Windows path separators Modify Webpack sourcemap parameters to account for Windows path separators. Oct 19, 2024
@Varriount Varriount force-pushed the fix-sourcemap-filters branch from 0303a35 to 8bca3eb Compare October 19, 2024 22:37
@rachel-fenichel
Copy link
Collaborator

@cpcallen can you take this one since it hits the build system?

@cpcallen cpcallen requested review from cpcallen and removed request for rachel-fenichel November 1, 2024 16:23
@cpcallen cpcallen changed the title Modify Webpack sourcemap parameters to account for Windows path separators. fix: Modify Webpack sourcemap parameters to account for Windows path separators Nov 1, 2024
@cpcallen cpcallen merged commit 58be365 into google:master Nov 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants