Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explicitly set the padding on workspace search buttons #2459

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

riknoll
Copy link
Contributor

@riknoll riknoll commented Sep 5, 2024

The basics

The details

Resolves

Fixes #2458

Proposed Changes

Fixes the buttons in the workspace search plugin widget in the Firefox browser by explicitly setting the button padding instead of relying on the user agent styles default.

Before:
image

After:
image

Reason for Changes

The padding on the buttons in the workspace search plugin is currently just using the padding specified by the browser's user agent style for buttons. In Chrome, that padding is 6px on the left and right which results in a correctly sized button. Firefox on the other hand has slightly smaller buttons (4px of padding) which results in the error show in the linked issue.

Test Coverage

N/A

Documentation

N/A

Additional Information

N/A

@riknoll riknoll requested a review from a team as a code owner September 5, 2024 21:15
@riknoll riknoll requested review from cpcallen and removed request for a team September 5, 2024 21:15
Copy link
Collaborator

@rachel-fenichel rachel-fenichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rachel-fenichel rachel-fenichel merged commit dbeec92 into google:master Sep 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workspace search plugin buttons are mis-sized in Firefox
3 participants