Drop "credentials" input and prep for 1.0 release #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verbanicm
reviewed
Nov 17, 2022
verbanicm
reviewed
Nov 17, 2022
verbanicm
reviewed
Nov 17, 2022
verbanicm
reviewed
Nov 17, 2022
sethvargo
force-pushed
the
sethvargo/one
branch
2 times, most recently
from
61715b1 to
e3ea979
Compare
This drops the long-deprecated "credentials" input and pulls many of the expensive integration tests into unit tests which assert the same behavior. It also switches to using the JSON output from the "gcloud app deploy" command instead of parsing the text output, since that has proven to be unstable.
sethvargo
force-pushed
the
sethvargo/one
branch
from
e3ea979 to
5d94fba
Compare
verbanicm
approved these changes
Nov 17, 2022
Merged
sethvargo
pushed a commit
that referenced
this pull request
Nov 17, 2022
## What's Changed * Drop "credentials" input and prep for 1.0 release by @sethvargo in #279 **Full Changelog**: v0.8.2...3177e3f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops the long-deprecated "credentials" input and pulls many of the expensive integration tests into unit tests which assert the same behavior. It also switches to using the JSON output from the "gcloud app deploy" command instead of parsing the text output, since that has proven to be unstable.
Closes #166
Closes #255
Closes #268
Closes #277
Closes #278