Skip to content

Commit

Permalink
chore!: upgrade to node16 (#243)
Browse files Browse the repository at this point in the history
  • Loading branch information
sethvargo authored Mar 8, 2022
1 parent e05056b commit 5fb3173
Show file tree
Hide file tree
Showing 9 changed files with 38 additions and 29 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/deploy-appengine-creds-it.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
name: with setup-gcloud
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- uses: google-github-actions/setup-gcloud@master
with:
project_id: ${{ secrets.APPENGINE_DEPLOY_PROJECT_ID }}
Expand Down Expand Up @@ -59,7 +59,7 @@ jobs:
name: with setup-gcloud - no project Id
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- uses: google-github-actions/setup-gcloud@master
with:
service_account_key: ${{ secrets.APPENGINE_DEPLOY_SA_KEY_JSON }}
Expand Down Expand Up @@ -106,7 +106,7 @@ jobs:
name: with base64 json creds
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Update app.yaml
run: |-
echo "service: ${{ github.job }}-${{ github.run_number }}" >> ${{ github.workspace }}/example-app/app.yaml
Expand Down Expand Up @@ -148,7 +148,7 @@ jobs:
name: with json creds
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Update app.yaml
run: |-
echo "service: ${{ github.job }}-${{ github.run_number }}" >> ${{ github.workspace }}/example-app/app.yaml
Expand Down Expand Up @@ -195,15 +195,15 @@ jobs:
id-token: 'write'

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Update app.yaml
run: |-
echo "service: ${{ github.job }}-${{ github.run_number }}" >> ${{ github.workspace }}/example-app/app.yaml
- uses: 'actions/setup-node@v2'
- uses: 'actions/setup-node@v3'
with:
node-version: '12.x'
node-version: '16.x'

- id: build
name: Build dist
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/deploy-appengine-inputs-it.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
name: with flags
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- uses: google-github-actions/setup-gcloud@master
with:
project_id: ${{ secrets.APPENGINE_DEPLOY_PROJECT_ID }}
Expand Down Expand Up @@ -67,10 +67,10 @@ jobs:
name: with bad inputs
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@master
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 12.x
node-version: 16.x
- id: build
name: Build dist
run: |-
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/deploy-appengine-it.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
name: with working directory
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- uses: google-github-actions/setup-gcloud@master
with:
project_id: ${{ secrets.APPENGINE_DEPLOY_PROJECT_ID }}
Expand Down Expand Up @@ -68,7 +68,7 @@ jobs:
name: with deliverable path
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- uses: google-github-actions/setup-gcloud@master
with:
project_id: ${{ secrets.APPENGINE_DEPLOY_PROJECT_ID }}
Expand Down Expand Up @@ -124,7 +124,7 @@ jobs:
name: with bad path
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- uses: google-github-actions/setup-gcloud@master
with:
project_id: ${{ secrets.APPENGINE_DEPLOY_PROJECT_ID }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/example-workflow.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:

runs-on: 'ubuntu-latest'
steps:
- uses: 'actions/checkout@v2'
- uses: 'actions/checkout@v3'

- uses: 'google-github-actions/auth@v0'
with:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ jobs:
build:
runs-on: 'ubuntu-latest'
steps:
- uses: 'actions/checkout@v2'
- uses: 'actions/checkout@v3'

- uses: 'actions/setup-node@v2'
- uses: 'actions/setup-node@v3'
with:
node-version: '12.x'
node-version: '16.x'

- name: 'npm build'
run: 'npm ci && npm run build'
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ jobs:
- 'macos-latest'

steps:
- uses: 'actions/checkout@v2'
- uses: 'actions/checkout@v3'

- uses: 'actions/setup-node@v2'
- uses: 'actions/setup-node@v3'
with:
node-version: 12.x
node-version: 16.x

- name: 'npm build'
run: 'npm ci && npm run build'
Expand Down
9 changes: 7 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,13 @@ background if not using in with the [`setup-gcloud` action][setup-gcloud].

## Prerequisites

This action requires Google Cloud credentials that are authorized to deploy an
App Engine Application. See the [Authorization](#authorization) section below for more information.
- This action requires Google Cloud credentials that are authorized to deploy
an App Engine Application. See the [Authorization](#authorization) section
below for more information.

- This action runs using Node 16. If you are using self-hosted GitHub Actions
runners, you must use runner version [2.285.0](https://github.com/actions/virtual-environments)
or newer.

## Usage

Expand Down
10 changes: 7 additions & 3 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,18 @@ inputs:
flags:
description: |-
Space separated list of other App Engine flags, examples can be found:
https://cloud.google.com/sdk/gcloud/reference/app/deploy#FLAGS. Ex
https://cloud.google.com/sdk/gcloud/reference/app/deploy#FLAGS. Ex
[email protected] --no-cache
required: false

outputs:
url:
description: URL of your App Engine Application

branding:
icon: 'code'
color: 'blue'

runs:
using: node12
main: dist/index.js
using: 'node16'
main: 'dist/index.js'
6 changes: 3 additions & 3 deletions example-app/app.yaml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# Copyright 2020 Google, LLC.
#
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
Expand All @@ -12,4 +12,4 @@
# See the License for the specific language governing permissions and
# limitations under the License.

runtime: nodejs12
runtime: nodejs16

0 comments on commit 5fb3173

Please sign in to comment.